DAML Engine: Remove token argument to SBU* builtins #7542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently pass the token to all builtins named `SBU*` aka the update builtins. Since we pass the token immediately on all call sites of these builtins, there's no point in passing the token at all. This PR removes the token passing for the `SBU*` builtins. Unfortunately, this does not improve execution performance. However, since it simplifies the code, I still consider it worthwhile. CHANGELOG_BEGIN CHANGELOG_END
hurryabit
force-pushed
the
update-builtins-no-token
branch
from
658b9f6 to
dc5f505
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently pass the token to all builtins named
SBU*aka theupdate builtins. Since we pass the token immediately on all call sites
of these builtins, there's no point in passing the token at all.
This PR removes the token passing for the
SBU*builtins.Unfortunately, this does not improve execution performance. However,
since it simplifies the code, I still consider it worthwhile.
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.
This change is