Only include stakeholder contracts in result of query #7291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the script service. We need to filter out divulged contracts since this should behave exactly like the ACS endpoint on the ledger API. changelog_begin changelog_end
cocreature
requested review from
hurryabit and
remyhaemmerle-da
as code owners
cocreature
force-pushed
the
query-divulge
branch
from
e30ca39 to
354073a
Compare
cocreature
changed the title
remyhaemmerle-da
approved these changes
Sep 1, 2020
daml-lf/interpreter/src/main/scala/com/digitalasset/daml/lf/scenario/ScenarioLedger.scala
Outdated
Show resolved
Hide resolved
...-script/runner/src/main/scala/com/digitalasset/daml/lf/engine/script/LedgerInteraction.scala
Outdated
Show resolved
Hide resolved
…enario/ScenarioLedger.scala Co-authored-by: Remy <remy.haemmerle@daml.com>
…ine/script/LedgerInteraction.scala Co-authored-by: Remy <remy.haemmerle@daml.com>
aherrmann-da
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the script service. We need to filter out divulged
contracts since this should behave exactly like the ACS endpoint on
the ledger API.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.