Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS codegen tests: use #!/usr/bin/env bash #7149

Merged
merged 1 commit into from
Aug 17, 2020
Merged

TS codegen tests: use #!/usr/bin/env bash #7149

merged 1 commit into from
Aug 17, 2020

Conversation

curiousleo-da
Copy link
Contributor

Fixes //language-support/ts/codegen/tests:build-and-lint-test on NixOS.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

@curiousleo-da curiousleo-da marked this pull request as ready for review August 17, 2020 07:00
@curiousleo-da curiousleo-da requested a review from a user August 17, 2020 07:00
ghost
ghost reviewed Aug 17, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems smart to me. I'd want @garyverhaegen-da to double-check though.

cocreature
cocreature approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

garyverhaegen-da
garyverhaegen-da suggested changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @curiousleo-da ! Thanks for the PR. The files under infra/macos are special, though, and should be updated separately (if at all). Would you mind removing those changes from this PR?

dev-env/bin/dad-add-source-dep.sh Outdated Show resolved Hide resolved
infra/macos/scripts/rebuild-crontask.sh Outdated Show resolved Hide resolved
infra/macos/scripts/run-agent.sh Outdated Show resolved Hide resolved
@curiousleo
Shebang: use #!/usr/bin/env bash
6744ac6 
Fixes //language-support/ts/codegen/tests:build-and-lint-test on NixOS.

changelog_begin
changelog_end
@curiousleo-da curiousleo-da changed the title Shebang: use #!/usr/bin/env bash TS codegen tests: use #!/usr/bin/env bash Aug 17, 2020
@curiousleo-da
Copy link
Contributor Author

Thanks all for the reviews!

Hi @curiousleo-da ! Thanks for the PR. The files under infra/macos are special, though, and should be updated separately (if at all). Would you mind removing those changes from this PR?

@garyverhaegen-da: absolutely. I've restricted the changes to just the TS codegen tests, which is what I probably should have done to start with. The updated PR should be ready to merge now.

garyverhaegen-da
garyverhaegen-da approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@garyverhaegen-da garyverhaegen-da merged commit 8f0970c into master Aug 17, 2020
@garyverhaegen-da garyverhaegen-da deleted the leo/fix-bash-nixos branch August 17, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

@aherrmann-da aherrmann-da aherrmann-da approved these changes

@cocreature cocreature cocreature approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
Standard-Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@curiousleo-da @cocreature @aherrmann-da @garyverhaegen-da @curiousleo