Make paths in assistant environment absolute. #7142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #6977. This PR adds some assistant tests, but regression tests and documentation should be added before the issue is closed. changelog_begin changelog_end
cocreature
added a commit
that referenced
this pull request
Oct 29, 2021
Let me provide some justification: 1. We used to have a bug around this in the assistant. This got fixed in #7142 together with unit tests. #7150 then added an integration test. Finally #8032 as part of refactoring also added a test for absolute paths. 2. As shown in #11218 those tests together currently take more than 50s (locally without load). 3. On the other hand, they don’t really seem to add any meaningful coverage over the unit tests. So overall, those tests don’t seem to test anything particularly useful that isn’t tested elsewhere while they are very slow so deleting them seems like the best strategy. changelog_begin changelog_end
7 tasks
cocreature
added a commit
that referenced
this pull request
Oct 29, 2021
…11461) Let me provide some justification: 1. We used to have a bug around this in the assistant. This got fixed in #7142 together with unit tests. #7150 then added an integration test. Finally #8032 as part of refactoring also added a test for absolute paths. 2. As shown in #11218 those tests together currently take more than 50s (locally without load). 3. On the other hand, they don’t really seem to add any meaningful coverage over the unit tests. So overall, those tests don’t seem to test anything particularly useful that isn’t tested elsewhere while they are very slow so deleting them seems like the best strategy. changelog_begin changelog_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6977. This PR adds some assistant tests, but regression tests and documentation should be added before the issue is closed.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.