Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox Classic: Privatize everything. #7130

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 13, 2020

We don't need to expose anything apart from what's necessary to run it. The internals are not for fiddling.

This also splits out LedgerBackedWriteService from SandboxIndexAndWriteService, because it's huge and mostly unrelated.

Fixes #7121.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay. It's not entirely clear to me why the sandbox-classic artifact would need such privatization, considering it shouldn't be used as a library to begin with.

@ghost
Copy link
Author

ghost commented Aug 14, 2020

I thought the same until #7121 was opened. 😉

@ghost ghost added the automerge label Aug 14, 2020
@mergify mergify bot merged commit dcb21dc into master Aug 14, 2020
@mergify mergify bot deleted the samir/ledger/sandbox-classic/privatize branch August 14, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SandboxIndexAndWriteService#inMemory is public but cannot be called
2 participants