kvutils/tools: If there's an error in reading a submission, crash. #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now the error is logged, but the program stalls, because the exception is outside any `Future`, and so the cleanup never happens. CHANGELOG_BEGIN CHANGELOG_END
ghost
self-requested a review
ghost
requested review from
dasormeter,
fabiotudone-da,
gerolf-da,
miklos-da,
mziolekda,
rautenrieth-da and
stefanobaghino-da
as code owners
miklos-da
approved these changes
Aug 13, 2020
ghost
added
the
mergify
bot
deleted the
samir/ledger/participant-state/kvutils/tools/fail-reading-properly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the error is logged, but the program stalls, because the exception is outside any
Future, and so the cleanup never happens.Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.