Document non-reproducible outputs #7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog_begin changelog_end
aherrmann-da
requested review from
hurryabit and
rautenrieth-da
as code owners
cocreature
approved these changes
Aug 13, 2020
| # This rule is not reproducible. `vsce package` generates a `.vsix` file which | ||
| # is just a zip archive. The order of entries in that archive is | ||
| # non-deterministic and the individual entries contain non-reproducible | ||
| # timestamps. |
There was a problem hiding this comment.
Could we unzip and rezip to fix this?
There was a problem hiding this comment.
Yes, I was hoping to find a way to do this with vsce directly, but failing that this should do it.
There was a problem hiding this comment.
Not much to be gained trying to fix this if we cannot fix Navigator. In the end, the thing we really want to be reproducible is the SDK tarball.
| @@ -64,6 +64,15 @@ nodejs_binary( | |||
|
|
|||
| # Builds the frontend single page application and bundles all output files | |||
| # (HTML + JavaScript + CSS + images) in a .tgz or .jar archive. | |||
| # This target is non-reproducible. The browsercheck and bundle outputs | |||
There was a problem hiding this comment.
Non-reproducible hashes sound very weird 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend webpack bundle and the vscode extension are non-reproducible outputs in the SDK release tarball. I looked into what makes them non-reproducible. I didn't succeed in making them reproducible, but this PR adds my findings as comments to the relevant Bazel targets.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.