Sandbox: More rigorous parsing for metrics reporters. #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the issue where a previously-valid value such as "graphite:server:1234" fails with a cryptic error message: "hostname can't be null". CHANGELOG_BEGIN - [Sandbox] Improved the error message when providing an invalid metric reporter as a command line argument. Now the error message always shows the correct syntax. CHANGELOG_END
ghost
requested review from
gerolf-da,
rautenrieth-da and
stefanobaghino-da
as code owners
|
BTW, I had to eyeball the error messages in the test logs to make sure they were legit. I didn't want to change too much in this PR, but I'd like to look into actually testing these error messages at some point. |
gerolf-da
approved these changes
Aug 14, 2020
|
I think that was a smart move. I didn't know @jberthold-da and co. were using it. 🙂 |
ghost
added
the
mergify
bot
deleted the
samir/ledger/sandbox-common/handle-errors-in-metrics-reporter-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the issue where a previously-valid value such as "graphite:server:1234" fails with a cryptic error message: "hostname can't be null".
Fixes #6994.
Changelog
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.