Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove more unused definitions, params, args from triggers Scala code #7032

Merged
merged 1 commit into from
Aug 5, 2020
Merged

remove more unused definitions, params, args from triggers Scala code #7032

merged 1 commit into from
Aug 5, 2020

Conversation

S11001001
Copy link
Contributor

As found by -Ywarn-unused in #6907. These were missed by #6983 because these parts of #6907's build plan weren't reachable when that PR was made.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@S11001001 S11001001 added automerge component/trigger-service Trigger service team/ledger-clients Related to the Ledger Clients team's components. labels Aug 5, 2020
@S11001001 S11001001 added this to the Trigger Service milestone Aug 5, 2020
@S11001001 S11001001 self-assigned this Aug 5, 2020
@S11001001 S11001001 mentioned this pull request Aug 5, 2020
Merged
17 tasks
cocreature
cocreature approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

rohanjr
rohanjr approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@rohanjr rohanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d2ee532 into master Aug 5, 2020
@mergify mergify bot deleted the triggers-2-Ywarn-unused branch August 5, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanjr rohanjr rohanjr approved these changes

@cocreature cocreature cocreature approved these changes

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees

@S11001001 S11001001

Labels
component/trigger-service Trigger service team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
Trigger Service
Development

Successfully merging this pull request may close these issues.
3 participants
@S11001001 @cocreature @rohanjr