rotate responsibility for release process #7011

garyverhaegen-da · 2020-08-05T13:28:27Z

This PR attempts to add some automation around assigning release management. The PR adds a file release/rotation; each week, the updated CI cron job will:

Open a PR for the new release [as current].
Assign the first user in the file to that PR.
Add the Standard-Change label to the PR.
Start the build for that PR [as current].
Open a new PR that rotates the release/rotate file, i.e. pushes back the first line to the end of the file.

This PR also adds mentions of the "release handler" (the first line of release/rotation) to the various messages we send to Slack along the release process.

The initial state of the release/rotation file has been created by listing all the volunteers (Language team, Application Runtime team, as well as @SamirTalwar-DA and @stefanobaghino-da) and piping the file through shuf. (Then I put myself at the top so I can hopefully iron out the issues with the first attempt.)

CHANGELOG_BEGIN
CHANGELOG_END

garyverhaegen-da · 2020-08-05T13:30:13Z

azure-pipelines.yml

@@ -475,10 +475,11 @@ jobs:
        condition: not(eq(variables['skip-github'], 'TRUE'))
      - bash: |
          set -euo pipefail
+          pr_handler=$(head -1 release/rotation | awk "${print $1}")


This step of the release process runs on the trigger commit on the master branch, so the release/rotation file is the right one. (As opposed to many steps in the release process that checkout the target commit.)

ghost · 2020-08-05T14:36:54Z

ci/cron/wednesday.yml

+                           -H "$AUTH" \
+                           --silent \
+                           --location \
+                           -d "{\"title\": \"$title\", \"head\": \"$branch\", \"base\": \"master\", \"body\": \"$body\"}" \


If you're wary about special characters in the title or body, you could do something like this:

jq -n --arg branch "$branch" --arg title "$title" --arg body "$body" '{"title": $title, "head": $branch, "base": "master", "body": $body}' \ | curl ... -d @- https://...

I did not know jq had such a syntax. Thanks!

ghost · 2020-08-05T14:38:18Z

ci/cron/wednesday.yml

+          local tmp
+          tmp=$(mktemp)
+          cp release/rotation $tmp
+          cat <(tail -n +2 $tmp) <(head -1 $tmp) > release/rotation


You don't need to get cat involved here.

Suggested change

cat <(tail -n +2 $tmp) <(head -1 $tmp) > release/rotation

(tail -n +2 $tmp; head -1 $tmp) > release/rotation

You always want to oust my cats. 😿

Let the cat sleep. It's had a hard day.

ghost · 2020-08-05T14:41:32Z

ci/cron/wednesday.yml

+              --definition-name "digital-asset.daml" \
+              --org "https://dev.azure.com/digitalasset" \
+              --project daml
+          echo $pr_number > $out


This doesn't seem to be used anywhere. I might be mistaken.

It's used to get the PR number so we can assign the Standard-Change label to it, assign the release handler, and mention it in the second PR message.

Aha, it's unused in the second open_pr, but not the first. Can I suggest making it an optional parameter, rather than calling mktemp?

Suggested change

echo $pr_number > $out

if [[ -n "$out" ]]; then

echo $pr_number > $out

fi

garyverhaegen-da · 2020-08-05T15:04:45Z

Finally confirmed working as intended (see #7020 & #7021).

cocreature

Great work, thank you very much! I’ll leave the Bash bikeshedding to @SamirTalwar 🙂

cocreature · 2020-08-05T14:22:31Z

azure-pipelines.yml

@@ -523,7 +524,14 @@ jobs:
        # using basic auth format:
        # https://username:password@github.com/:user/:repo.git
        # This series of pipes extracts the `username:password` part.
-        AUTH="$(git config remote.origin.url | grep -o "://.*:.*@" | cut -c4- | rev | cut -c2- | rev)"
+        #
+        # It looks like in some cases the credentials get stored separately as


Was this always the case and we just didn’t hit it so far or did something change?

I'm not sure. It's probably a git version change between our GCP-hosted nodes and the Azure ones.

Making it work for both seemed like less effort than trying to figure out when I should support which one.

azure-pipelines.yml

ci/cron/wednesday.yml

@stefanobaghino-da

This PR attempts to add some automation around assigning release management. The PR adds a file `release/rotation`; each week, the updated CI cron job will: - Open a PR for the new release [as current]. - Assign the first user in the file to that PR. - Add the Standard-Change label to the PR. - Start the build for that PR [as current]. - Open a new PR that rotates the `release/rotate` file, i.e. pushes back the first line to the end of the file. This PR also adds mentions of the "release handler" (the first line of `release/rotation`) to the various messages we send to Slack along the release process. The initial state of the `release/rotation` file has been created by listing all the volunteers (Language team, Application Runtime team, as well as @SamirTalwar-DA and @stefanobaghino-da) and piping the file through `shuf`. (Then I put myself at the top so I can hopefully iron out the issues with the first attempt.) CHANGELOG_BEGIN CHANGELOG_END

stefanobaghino-da · 2020-08-17T07:26:53Z

Nice! Is there a way for people to know in advance about this?

cocreature · 2020-08-17T07:29:11Z

@stefanobaghino-da We just go through the file top to bottom so you can just look at the entries to see when you are up.

stefanobaghino-da · 2020-08-17T07:53:05Z

How would I go about that? I don't know who was last.

cocreature · 2020-08-17T07:54:47Z

The file is rotated every week so the one at the top is always the next one.

garyverhaegen-da · 2020-08-17T09:11:57Z

Nice! Is there a way for people to know in advance about this?

Ah, sorry. I discussed it in team meetings, but obviously that doesn't work for you and @SamirTalwar-DA. Happy to answer any further questions here, on Slack, or on a call, though the gist of it really is just that when it's your turn, you will be @-mentioned both in relevant PRs and relevant Slack messages. (That is, if it works as intended — it did not quite do so last week, but I tried to fix it, so maybe this week it will.)

garyverhaegen-da requested review from cocreature and a user August 5, 2020 13:28

garyverhaegen-da commented Aug 5, 2020

View reviewed changes

This was referenced Aug 5, 2020

release 1.4.0-snapshot.20200805.4912.0.bfa73dbf #7013

Closed

release 1.4.0-snapshot.20200805.4914.0.e85347a9 #7014

Closed

garyverhaegen-da force-pushed the release-rotation branch from b41b795 to 0a521a1 Compare August 5, 2020 14:41

This was referenced Aug 5, 2020

rotate release duty after 1.4.0-snapshot.20200805.4916.0.b41b7957 #7017

Closed

release 1.4.0-snapshot.20200805.4916.0.b41b7957 #7016

Closed

ghost reviewed Aug 5, 2020

View reviewed changes

This was referenced Aug 5, 2020

release 1.5.0-snapshot.20200805.4909.0.05f10412 #7018

Closed

rotate release duty after 1.5.0-snapshot.20200805.4909.0.05f10412 #7019

Closed

garyverhaegen-da force-pushed the release-rotation branch from 05f1041 to 2a7ba56 Compare August 5, 2020 15:01

cocreature approved these changes Aug 5, 2020

View reviewed changes

garyverhaegen-da force-pushed the release-rotation branch from 2a7ba56 to 9f4599d Compare August 5, 2020 16:25

garyverhaegen-da mentioned this pull request Aug 5, 2020

Tracking Windows errors #6262

Closed

garyverhaegen-da merged commit 00f3de6 into master Aug 5, 2020

garyverhaegen-da deleted the release-rotation branch August 5, 2020 16:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rotate responsibility for release process #7011

rotate responsibility for release process #7011

garyverhaegen-da commented Aug 5, 2020

garyverhaegen-da Aug 5, 2020

ghost Aug 5, 2020

garyverhaegen-da Aug 5, 2020

ghost Aug 5, 2020

garyverhaegen-da Aug 5, 2020

ghost Aug 5, 2020

ghost Aug 5, 2020

garyverhaegen-da Aug 5, 2020

ghost Aug 5, 2020

garyverhaegen-da commented Aug 5, 2020

cocreature left a comment

cocreature Aug 5, 2020

garyverhaegen-da Aug 5, 2020

stefanobaghino-da commented Aug 17, 2020

cocreature commented Aug 17, 2020

stefanobaghino-da commented Aug 17, 2020

cocreature commented Aug 17, 2020

garyverhaegen-da commented Aug 17, 2020 •

edited

Loading

	cat <(tail -n +2 $tmp) <(head -1 $tmp) > release/rotation
	(tail -n +2 $tmp; head -1 $tmp) > release/rotation

rotate responsibility for release process #7011

rotate responsibility for release process #7011

Conversation

garyverhaegen-da commented Aug 5, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garyverhaegen-da commented Aug 5, 2020

cocreature left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stefanobaghino-da commented Aug 17, 2020

cocreature commented Aug 17, 2020

stefanobaghino-da commented Aug 17, 2020

cocreature commented Aug 17, 2020

garyverhaegen-da commented Aug 17, 2020 • edited Loading

garyverhaegen-da commented Aug 17, 2020 •

edited

Loading