Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override the version of JOPT Simple from scala_rules #6621

Merged
merged 3 commits into from
Jul 6, 2020

Conversation

remyhaemmerle-da
Copy link
Collaborator

The PR overrides the JOpt Simple version with 4.6.

The scala_rules introduces a dependency to version 5.0.3 of JOpt Simple. However JMH library is built against version 4.6 of JOpt Simple. In current state the command line parsing functionality of JMH is partially broken. One can see the issue by running bazel run daml-lf/scenario-interpreter:scenario-perf-test -- -h with current master branch.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@remyhaemmerle-da remyhaemmerle-da added this to the Maintenance milestone Jul 6, 2020
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Patching rules_scala might have been easier but now that we have the change already we might as well go this route.

@remyhaemmerle-da remyhaemmerle-da merged commit 6497dfa into master Jul 6, 2020
@remyhaemmerle-da remyhaemmerle-da deleted the remy-fix-jmh branch July 6, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants