Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the copyright header from the skeleton #6581

Merged
merged 2 commits into from
Jul 2, 2020
Merged

Remove the copyright header from the skeleton #6581

merged 2 commits into from
Jul 2, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Jul 2, 2020 •
edited
Loading

It doesn't make sense to annoy our users with our copyright for on a
template. And the over abundance of empty lines has annoyed me so many
times.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

cocreature
cocreature approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

sofiafaro-da
sofiafaro-da approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@sofiafaro-da sofiafaro-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@hurryabit hurryabit force-pushed the less-empty-lines-in-skeleton branch from dfc432a to 8c98bc9 Compare July 2, 2020 11:23
@hurryabit
Remove the copyright header from the skelton
41e846b 
It doesn't make sense to annoy our users with our copyright for on a
template. And the over abundance of empty lines has annoyed me so many
times.
@hurryabit hurryabit force-pushed the less-empty-lines-in-skeleton branch from 8c98bc9 to 41e846b Compare July 2, 2020 11:23
@hurryabit hurryabit changed the title Remove two useless empty lines from the skeleton Remove the copyright header from the skeleton Jul 2, 2020
cocreature
cocreature approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@hurryabit
Add NO_AUTO_COPYRIGHT file
3fa0069 
CHANGELOG_BEGIN
CHANGELOG_END
@mergify mergify bot merged commit a2f2880 into master Jul 2, 2020
@mergify mergify bot deleted the less-empty-lines-in-skeleton branch July 2, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyverhaegen-da garyverhaegen-da garyverhaegen-da approved these changes

@cocreature cocreature cocreature approved these changes

@sofiafaro-da sofiafaro-da Awaiting requested review from sofiafaro-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hurryabit @cocreature @garyverhaegen-da @sofiafaro-da