Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only ship disclosure information once in scenario service #6578

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Only ship disclosure information once in scenario service #6578

merged 1 commit into from
Jul 2, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Jul 2, 2020 •
edited
Loading

Currently, the scenario service ships the disclosure information of a
transaction twice. One of the two copies is completely unused. This PR
simply deletes it. I hope this reduces confusion in the future.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This change is Reviewable

@hurryabit hurryabit requested a review from cocreature July 2, 2020 10:16
cocreature
cocreature approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

remyhaemmerle-da
remyhaemmerle-da approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks.

@hurryabit
Only ship disclosure information once in scenario service
2f3f52c 
Currently, the scenario service ships the disclosure information of a
transaction twice. One of the two copies is completely unused. This PR
simply deletes it. I hope this reduces confusion in the future.

CHANGELOG_BEGIN
CHANGELOG_END
@hurryabit hurryabit force-pushed the scenario-service-disclose-once branch from ffbbd0d to 2f3f52c Compare July 2, 2020 12:16
@mergify mergify bot merged commit 6dc2c9c into master Jul 2, 2020
@mergify mergify bot deleted the scenario-service-disclose-once branch July 2, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyhaemmerle-da remyhaemmerle-da remyhaemmerle-da approved these changes

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hurryabit @cocreature @remyhaemmerle-da