Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger service: Remove data in messages from TriggerRunnerImpl to Server #6554

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

rohanjr
Copy link
Contributor

@rohanjr rohanjr commented Jun 30, 2020

Small refactor for shorter code

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@rohanjr rohanjr requested a review from cocreature June 30, 2020 22:02
@rohanjr rohanjr changed the title Trigger service: Remove data from message sent from TriggerRunnerImpl to Server Trigger service: Remove data in messages from TriggerRunnerImpl to Server Jun 30, 2020
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like deleted stuff 🔥

@rohanjr rohanjr merged commit 546c75b into master Jul 1, 2020
@rohanjr rohanjr deleted the trigger-service-message-param branch July 1, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants