Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch CI nodes from n1-standard-8 to c2-* #6514

Merged
merged 2 commits into from
Jun 27, 2020
Merged

Conversation

garyverhaegen-da
Copy link
Contributor

A while back (#4520), I did a bunch of performance tests when trying to size up the requirements for the hosted macOS nodes we needed to buy. As part of that testing, it looked like c2-standard-8 nodes were faster (full build down from ~95 to ~75 minutes) and marginally cheaper ($0.4176 vs $0.4280) than the n1-standard-8 we are currently using.

Then I got distracted, and I forgot to upgrade our existing machines.

CHANGELOG_BEGIN
CHANGELOG_END

A while back (#4520), I did a bunch of performance tests when trying to
size up the requirements for the hosted macOS nodes we needed to buy. As
part of that testing, it looked like `c2-standard-8` nodes were faster
(full build down from ~95 to ~75 minutes) and marginally cheaper
($0.4176 vs $0.4280) than the `n1-standard-8` we are currently using.

Then I got distracted, and I forgot to upgrade our existing machines.

CHANGELOG_BEGIN
CHANGELOG_END
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost
Copy link

ghost commented Jun 26, 2020

Awesome. I had the same results when running performance tests on Sandbox, so this isn't surprising.

@garyverhaegen-da
Copy link
Contributor Author

terraform apply just completed successfully (after fixing a typo), and as expected only touched the Linux and Windows CI nodes. I'll report back in an hour or so when (hopefully) the new nodes are up and running.

@garyverhaegen-da
Copy link
Contributor Author

Node creation is failing because we apparently have a quota of maximum 24 C2 CPUs. At the moment we have 2 Windows nodes and one Linux node starting up. I may have to revert this depending on how long it takes to adjust the quotas.

@garyverhaegen-da
Copy link
Contributor Author

It looks like our quota increase request was small enough to be approved automatically, so nodes should be coming up soon-ish (they say about 15 minutes for the change to take effect).

@garyverhaegen-da
Copy link
Contributor Author

All nodes are now created at the GCP level; some are still booting up, but the ones we do have have run successful jobs (this PR), so it looks like we're in the clear.

@garyverhaegen-da garyverhaegen-da merged commit c8f31ca into master Jun 27, 2020
@garyverhaegen-da garyverhaegen-da deleted the better-ci-nodes branch June 27, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants