Feedback button #6500
Feedback button #6500
Conversation
Changed the position of the 'Thumbs up/down' button to be in the bottom right corner above the 'Feedback' button. Added SASS to remove both buttons for mobile (as we were getting a lot of gibberish feedback CHANGELOG_START CHANGELOG_END
Changed the position of the 'Thumbs up/down' button to be in the bottom right corner above the 'Feedback' button. Added SASS to remove both buttons for mobile (as we were getting a lot of gibberish feedback CHANGELOG_START CHANGELOG_END
There was a problem hiding this comment.
I’ve spent 20 minutes trying to find the new feedback button after running the preview script on this PR and I still failed. Can you send me a screenshot? 🙂
Side note: the feedback button on the current docs site also gets blocked by ublock so there is a reasonable chance it doesn’t actually work for a lot of people.
|
Ah, great point @cocreature 😄 You should be able to see it now. The problem is that Mopinion (our 3rd party tool used for the feedback form) deploys all the forms we ever wanna use on the website so I had to create rules what forms to show when (e.g., don't wanna show the "Tutorial feedback" form on docs and vice-versa don't wanna show docs' feedback form on Katacoda scenarios). Added a rule to show the form if it's also coming from http://127.0.0.1:8000/
|
| @@ -268,7 +260,13 @@ | |||
| {% endif %} | |||
| {% endif %} | |||
|
|
|||
| {%- if url_root != './' %} | |||
| <div id="inpageContent"></div> | |||
There was a problem hiding this comment.
This looks strange. Why do we put an empty div here? Is some JS going to render into this?
There was a problem hiding this comment.
No, it's not gonna render. Just copy/pasted the old code that is used to determine if the page is docs.dam.com or not (if it is then don't show the feedback form)
There was a problem hiding this comment.
What happened to the <a onclick=...>Detailed Feedback</a> link?
There was a problem hiding this comment.
It’s redundant. Previously, we had the blue feedback button that you can see in the screenshot at the bottom right and the detailed feedback button at the top and they both do the same thing. Now that the thumbsup/thumbsdown arrows are directly above the button on the bottom right there is no point in having the separate link.
There was a problem hiding this comment.
That makes sense. Thanks for the explanation.
|
Added |
Changed the position of the 'Thumbs up/down' button to be in the bottom right corner above the 'Feedback' button. Added SASS to remove both buttons for mobile (as we were getting a lot of gibberish feedback
CHANGELOG_START
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.