Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove purge_old_agents #6439

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Conversation

garyverhaegen-da
Copy link
Contributor

This script was supposed to remove old agents from the Azure Pipelines UI. It may have been useful at some time (notably, when we used ephemeral instances, they did not necessarily get to run their shutdown script), but as it stands now, it's broken. The output from that step ends in:

error: 2 derivations need to be built, but neither local builds ('--max-jobs') nor remote builds ('--builders') are enabled

after listing the nix packages it would build. Furthermore, it does not seem to be useful as I have not seen any spurious entry in the agents list on Azure since we switched to permanent nodes, on either the Linux or Windows side (and this would only run on Linux, if it ran).

I'm also not convinced it ever ran, as I used to see a lot of spurious machines on both Linux and Windows when we did use ephemeral instances.

CHANGELOG_BEGIN
CHANGELOG_END

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

This script was supposed to remove old agents from the Azure Pipelines
UI. It may have been useful at some time (notably, when we used
ephemeral instances, they did not necessarily get to run their shutdown
script), but as it stands now, it's broken. The output from that step
ends in:

```
error: 2 derivations need to be built, but neither local builds ('--max-jobs') nor remote builds ('--builders') are enabled
```

after listing the nix packages it would build. Furthermore, it does not
seem to be useful as I have not seen any spurious entry in the agents
list on Azure since we switched to permanent nodes, on either the Linux
or Windows side (and this would only run on Linux, if it ran).

I'm also not convinced it ever ran, as I used to see a lot of spurious
machines on both Linux and Windows when we did use ephemeral instances.

CHANGELOG_BEGIN
CHANGELOG_END
@garyverhaegen-da garyverhaegen-da force-pushed the remove-remove-nodes-from-linux-ci branch from c893f6e to 1b8a6a3 Compare June 20, 2020 14:25
@garyverhaegen-da
Copy link
Contributor Author

Successfully applied.

@garyverhaegen-da garyverhaegen-da merged commit 2923048 into master Jun 20, 2020
@garyverhaegen-da garyverhaegen-da deleted the remove-remove-nodes-from-linux-ci branch June 20, 2020 15:37
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants