Trigger service: Write packages to database if we have one #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to recover state after the service shuts down or crashes. We add a method to the RunningTriggerDao to persistPackages. This only does something in the case of a DbTriggerDao. In any case the Server keeps a package map in memory as it's required to construct a trigger runner. I only write the main package dalf for now until I figure out how to fix my traversal of the package list. changelog_begin changelog_end
rohanjr
force-pushed
the
trigger-service-persist-dalfs
branch
from
965e6a0 to
eed0754
Compare
rohanjr
force-pushed
the
trigger-service-persist-dalfs
branch
from
44e53f9 to
b5f0efc
Compare
rohanjr
requested review from
aherrmann-da,
cocreature and
hurryabit
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to recover state after the service shuts down or crashes.
We add a method to the RunningTriggerDao to persistPackages. This only
does something in the case of a DbTriggerDao. In any case the Server
keeps a package map in memory as it's required to construct a trigger runner.
Uploads of existing packages is considered harmless.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.