Add migration test for divulgence #6376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #6349 changelog_begin changelog_end
stefanobaghino-da
requested review from
aherrmann-da,
cocreature and
garyverhaegen-da
as code owners
cocreature
approved these changes
Jun 17, 2020
| where | ||
| signatory owner | ||
|
|
||
| nonconsuming choice Fetch: Asset |
There was a problem hiding this comment.
Side note: Is there a particular reason why we do not have a ledger API command for this? I keep assuming this exists until I remember it doesn’t.
There was a problem hiding this comment.
Wild guess: preventing contract information leakage do divulgees unless it was explicitly allowed by the model (as in this case)? @gerolf-da do you have something to share here?
cocreature
reviewed
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6349
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.