A terser .gitignore file. #6324
Conversation
I trimmed _.gitignore_ to the stuff that looked like it was still useful (at least, to me). Most of what's in there seemed like remnants of previous build systems (Buck, Stack, etc.). Other stuff includes editor-specific configuration files, which you can add to your global _.gitignore_ (`git config --global core.excludesfile ~/.gitignore`). I left the macOS _.DS_Store_ files in, even though I believe they should also go into your global, machine-specific _.gitignore_ file, because eventually someone's going to check them in otherwise. On my machine, this has exactly the same effect as the longer one. However, it's highly likely that I've overlooked something; let me know and I can add it back. CHANGELOG_BEGIN CHANGELOG_END
ghost
requested review from
There was a problem hiding this comment.
I’m not a huge fan of telling people to add stuff to their global gitignore. Yes you can do it and it might technically be the right thing to do but adding it here avoids committing it accidentally and doesn’t do any harm if you do have it in your global gitignore.
|
OK, which editors should we support? I see emacs and vim backup files in there, Ensime, Eclipse, and IntelliJ IDEA. However, there could be 10 more that I don't recognize. Happy to add them back if we can identify the ones we care about. (And add in whatever was missing for those editors.) |
|
I would keep all editor-specific stuff and only remove stuff that is explicitly obsolete (e.g. references to rattle, cabal files or stack). |
|
If you don’t recognize something, it’s probably reasonable to remove it I guess. |
|
I added back in editor files that I recognized. Hopefully that's good enough for now. We can always add more. |
I guess we really don't want people checking these files in by accident.
ghost
added
the
I trimmed .gitignore to the stuff that looked like it was still useful (at least, to me). Most of what's in there seemed like remnants of previous build systems (Buck, Stack, etc.). Other stuff includes editor- and OS-specific configuration files; I've left in what I recognized.
I've tried to categorize the files. This helps with keeping the file trim.
On my machine, this has exactly the same effect as the longer one. However, it's highly likely that I've overlooked something; let me know and I can add it back.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.