Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate data-dependencies test DARs #6320

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Validate data-dependencies test DARs #6320

merged 2 commits into from
Jun 12, 2020

Conversation

aherrmann-da
Copy link
Contributor

Adds validate-dar test cases for data-dependencies compatibility tests as suggested in #6313 (review).

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

cocreature
cocreature approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@aherrmann-da aherrmann-da mentioned this pull request Jun 12, 2020
Closed
aherrmann added 2 commits June 12, 2020 17:05
@aherrmann
Validate data-dependencies test DARs
6583c4d 
In addition to building the coin upgrade DAR with data-dependencies on
the coin1 and coin2 packages built with an older SDK, this will also
define cases that run `damlc validate-dar` on the compiled coin upgrade
package.

changelog_begin
changelog_end
@aherrmann
fmt
eed0977
@aherrmann-da aherrmann-da force-pushed the compatibility-data-deps branch from 3114217 to eed0977 Compare June 12, 2020 15:05
@mergify mergify bot merged commit 2628e18 into master Jun 12, 2020
@mergify mergify bot deleted the compatibility-data-deps branch June 12, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

@garyverhaegen-da garyverhaegen-da Awaiting requested review from garyverhaegen-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aherrmann-da @cocreature @aherrmann