-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration test for contract key transfers #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
reviewed
Jun 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
compatibility/sandbox-migration/runner/Migration/KeyTransfer.hs
Outdated
Show resolved
Hide resolved
stefanobaghino-da
requested review from
aherrmann-da and
garyverhaegen-da
as code owners
June 11, 2020 20:35
cocreature
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
compatibility/sandbox-migration/runner/Migration/KeyTransfer.hs
Outdated
Show resolved
Hide resolved
compatibility/sandbox-migration/runner/Migration/KeyTransfer.hs
Outdated
Show resolved
Hide resolved
compatibility/sandbox-migration/runner/Migration/KeyTransfer.hs
Outdated
Show resolved
Hide resolved
compatibility/sandbox-migration/runner/Migration/KeyTransfer.hs
Outdated
Show resolved
Hide resolved
stefanobaghino-da
added a commit
that referenced
this pull request
Jun 12, 2020
stefanobaghino-da
force-pushed
the
ste/6238
branch
from
June 12, 2020 10:28
986a95a
to
b31d296
Compare
stefanobaghino-da
force-pushed
the
ste/6238
branch
from
June 12, 2020 10:56
b31d296
to
472ae27
Compare
changelog_begin changelog_end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6238
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.