Modify the cache URL instead of relying on platform_suffix #6273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocreature
requested review from
aherrmann-da and
garyverhaegen-da
as code owners
For some reason, platform_suffix doesn’t seem to provide enough isolation to fix the “undeclared inclusion” errors even though it does fix the issues for me locally. This PR tries to address the problem by switching from `platform_suffix` to modifying the actual URL of the cache. To avoid leaking stuff from the local cache, I’ve added a clean --expunge for now. We should be able to remove this once nodes have been reset tomorrow. It will slow down nodes but that is clearly better than having everything fail. changelog_begin changelog_end
cocreature
force-pushed
the
platform-suffix-url
branch
from
9e4c39b to
3a46c21
Compare
cocreature
commented
Jun 9, 2020
| @@ -2,7 +2,6 @@ | |||
| # flag: --noremote_accept_cached | |||
| build:darwin --remote_http_cache=https://bazel-cache.da-ext.net | |||
| build:linux --remote_http_cache=https://bazel-cache.da-ext.net | |||
| build:windows-ci --remote_http_cache=https://bazel-cache.da-ext.net/v1 | |||
There was a problem hiding this comment.
I don’t see an advantage of including it here given that caching only works in CI anyway (and even there it mostly doesn’t work 😢) and having it duplicated creeps me out a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, platform_suffix doesn’t seem to provide enough
isolation to fix the “undeclared inclusion” errors even though it does
fix the issues for me locally.
This PR tries to address the problem by switching from
platform_suffixto modifying the actual URL of the cache.To avoid leaking stuff from the local cache, I’ve added a clean
--expunge for now. We should be able to remove this once nodes have
been reset tomorrow. It will slow down nodes but that is clearly
better than having everything fail.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.