DAML-LF: split com.daml.lf.types.Ledger #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We split the object com.daml.lf.types.ledger in three: - one part in `com.daml.lf.ledger.` (in //daml-lf/transaction) for the part relative to EventId (shares between scenario service and sandbox) - one part in `com.daml.lf.ledger.` (in //daml-lf/interpreter) for the part common to Blinding and Scenario - one part in `com.daml.lf.scenario.` (in //daml-lf/interpreter) for the part specific to Scenario fixes #6260 CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
requested review from
cocreature,
hurryabit and
rautenrieth-da
as code owners
stefanobaghino-da
approved these changes
Jun 8, 2020
remyhaemmerle-da
changed the title
com.daml.lf.types.Ledger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We split the object
com.daml.lf.types.ledger.Ledgerin three:com.daml.lf.ledger.(in //daml-lf/transaction) for the code relative toEventIdshared between scenario service and sandboxcom.daml.lf.ledger.(in //daml-lf/interpreter) for the code relative toEnrichedTransactionshared between scenario service and blinding logiccom.daml.lf.scenario.(in //daml-lf/interpreter) for the code part specific to scenario servicefixes #6260
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.