Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sha256sums to releases #6263

Merged
merged 1 commit into from
Jun 8, 2020
Merged

add sha256sums to releases #6263

merged 1 commit into from
Jun 8, 2020

Conversation

garyverhaegen-da
Copy link
Contributor

Based on discussion on #6258.

CHANGELOG_BEGIN
CHANGELOG_END

cocreature
cocreature approved these changes Jun 8, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

azure-pipelines.yml Outdated
@@ -430,6 +430,7 @@ jobs:
for f in *; do
gpg --homedir $GPG_DIR -ab $f
done
sha256sum $(find . -type f | sort) > sha256sums
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How reasonable do you think it would be to manually add this for the last stable releases and snapshots since 1.2 (since with your and my pruning strategy we do not care about older snapshots after Wednesday)? So 1.0.0, 1.0.1 and 1.1.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very reasonable. I'll try to take care of it today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, moved the sha computation above the loop so the resulting file gets signed for future releases (obviously won't be for the manually added ones on older releases), as the sha of the signature files seems less valuable than the signature on the sha file.

@garyverhaegen-da
add sha256sums to releases
1d6c17c 
Based on discussion on #6258.

CHANGELOG_BEGIN
CHANGELOG_END
@garyverhaegen-da garyverhaegen-da force-pushed the add-checksums-to-releases branch from 17e3abe to 1d6c17c Compare June 8, 2020 13:57
@mergify mergify bot merged commit 7735acb into master Jun 8, 2020
@mergify mergify bot deleted the add-checksums-to-releases branch June 8, 2020 14:19
@garyverhaegen-da
Copy link
Contributor Author

I've manually uploaded the results of

for r in $(curl https://api.github.com/repos/digital-asset/daml/releases -s | jq -c '.[] | [.tag_name, [.assets[] | .browser_download_url | select ( . | contains(".asc") | not)]]'); do dir=$(echo $r | jq -r '.[0]'); mkdir $dir; cd $dir; parallel wget ::: $(echo $r | jq -r '.[1][]'); sha256sum $(find . -type f | sort) > sha256sums; cd ..; done

to all releases back to 1.0.0, i.e.:

v1.0.0
v1.0.1
v1.0.1-snapshot.20200417.3908.1.722bac90
v1.0.1-snapshot.20200424.3917.0.16093690
v1.1.0-snapshot.20200422.3991.0.6391ee9f
v1.1.0-snapshot.20200430.4057.0.681c862d
v1.1.0-snapshot.20200506.4107.0.7e448d81
v1.1.1
v1.2.0-snapshot.20200513.4172.0.021f4af3
v1.2.0-snapshot.20200520.4224.0.2af134ca
v1.2.0-snapshot.20200520.4228.0.595f1e27
v1.2.0-snapshot.20200527.4268.0.acc5a21c
v1.2.0-snapshot.20200528.4309.0.f619dea3
v1.2.0-snapshot.20200602.4310.0.1c18058f
v1.3.0-snapshot.20200603.4345.0.1386abc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyverhaegen-da @cocreature