Fix waitForSelector calls in create-daml-app-tests #6253
Conversation
`waitForSelector` returns immediately if the selector is already present (which is documented). This means that the waitForSelector after the second follow isn’t doing anything since we already waited for after the first follow. `waitForFunction` seemed like the simplest solution and doesn’t require patching the HTML which is a bit finnicky in the compat tests. changelog_begin changelog_end
cocreature
requested review from
aherrmann-da and
garyverhaegen-da
as code owners
| await page1.waitForFunction( | ||
| () => document.querySelectorAll(".test-select-following").length == 2 | ||
| ); |
There was a problem hiding this comment.
Doesn't this make the length check below redundant?
expect(followingList11).toHaveLength(2);
There was a problem hiding this comment.
Kind of but it seemed reasonable to keep the assertion separate from the check for how long we wait. Otherwise this is easy to get lost during refactoring.
| await page2.waitForFunction( | ||
| () => document.querySelectorAll(".test-select-following").length == 2 | ||
| ); |
There was a problem hiding this comment.
waitForSelector returns immediately if the selector is already present (which is documented). ...
page2 is a separate result of newUiPage than page1. Do I understand correctly that the presence of .test-select-following on page1 influences the query on page2? How is that happening?
There was a problem hiding this comment.
I’m not following, we waited on page2 before, we wait on page2 now.
There was a problem hiding this comment.
Hmm, nevermind, I misread the description of the issue.
waitForSelectorreturns immediately if the selector is alreadypresent (which is documented). This means that the waitForSelector
after the second follow isn’t doing anything since we already waited
for after the first follow.
waitForFunctionseemed like the simplestsolution and doesn’t require patching the HTML which is a bit finnicky
in the compat tests.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.