Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger Service: Tweak error handling in listTriggers helper #6247

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Trigger Service: Tweak error handling in listTriggers helper #6247

merged 1 commit into from
Jun 5, 2020

Conversation

rohanjr
Copy link
Contributor

@rohanjr rohanjr commented Jun 5, 2020

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@rohanjr
Tweak error handling in listTriggers helper
6c40108 
changelog_begin
changelog_end
@rohanjr rohanjr requested a review from shayne-fletcher June 5, 2020 20:10
shayne-fletcher
shayne-fletcher approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@shayne-fletcher shayne-fletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mergify mergify bot merged commit 3159c61 into master Jun 5, 2020
@mergify mergify bot deleted the trigger-service-list-refactor branch June 5, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayne-fletcher shayne-fletcher shayne-fletcher approved these changes

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

@cocreature cocreature Awaiting requested review from cocreature

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanjr @shayne-fletcher