DAML profiler: Evaluate arguments before open event #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a bug where the profiler wrote open events for functions _before_ evaluating their arguments. However, in a call-by-value language such as DAML, arguments are evaluated before entering a function and the profiler should reflect that. This PR also adds a regression test. CHANGELOG_BEGIN CHANGELOG_END
shayne-fletcher
approved these changes
Jun 4, 2020
remyhaemmerle-da
approved these changes
Jun 5, 2020
nickchapman-da
approved these changes
Jun 5, 2020
| @@ -731,16 +726,22 @@ object Speedy { | |||
| } | |||
|
|
|||
| /** The function-closure and arguments have been evaluated. Now execute the body. */ | |||
| final case class KFun(body: SExpr, frame: Frame, actuals: util.ArrayList[SValue]) | |||
| final case class KFun(closure: PClosure, actuals: util.ArrayList[SValue]) | |||
There was a problem hiding this comment.
Nice. Embedding the PClosure in the KFun, instead of it's components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the profiler wrote open events for functions
before evaluating their arguments. However, in a call-by-value
language such as DAML, arguments are evaluated before entering a
function and the profiler should reflect that.
This PR also adds a regression test.
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.
This change is