Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify exercise snippet #6232

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Simplify exercise snippet #6232

merged 1 commit into from
Jun 4, 2020

Conversation

cocreature
Copy link
Contributor

This is just not general enough to be useful. In particular, it
completely falls apart for somethin like submit x (exercise …) in
scenarios.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Simplify exercise snippet
e8e872c 
This is just not general enough to be useful. In particular, it
completely falls apart for somethin like submit x (exercise …) in
scenarios.

changelog_begin
changelog_end
@cocreature cocreature requested a review from hurryabit as a code owner June 4, 2020 19:59
dimitri-da
dimitri-da approved these changes Jun 4, 2020
View reviewed changes
Copy link

@dimitri-da dimitri-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a catch all but definitely better that what we have right now

@dimitri-da
Copy link

cool branch name

@cocreature cocreature merged commit 884d4d8 into master Jun 4, 2020
@cocreature cocreature deleted the snippets-suck branch June 4, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitri-da dimitri-da dimitri-da approved these changes

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cocreature @dimitri-da