-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engine: Centralize the place where value version is inferred. #6229
Conversation
CHANGELOG_BEGIN CHANGELOG_END
12149c1
to
a922214
Compare
@@ -28,7 +28,7 @@ final class Conversions( | |||
// We need the mapping for converting error message so we manually add it here. | |||
private val ptxCoidToNodeId = machine.ptx.nodes | |||
.collect { | |||
case (nodeId, node: N.NodeCreate.WithTxValue[V.ContractId]) => | |||
case (nodeId, node @ N.NodeCreate(_, _, _, _, _, _)) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current state we should have to add a PartialTransaction.Value1 and some
WithPartialTransactionValue` types.
I will see later if it is worthwhile to add it.
def convertKeyWithMaintainers[Val]( | ||
convertValue: Val => Value, | ||
key: N.KeyWithMaintainers[Val], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More like coYonedanvertKeyWithMaintainers
?
...r/scenario-service/server/src/main/scala/com/digitalasset/daml/lf/scenario/Conversions.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Compall <stephen.compall@daml.com>
debcd48
to
a9f6ec1
Compare
We move inference of value versions in a single place (when finalizing the
PartialTransacion
)In an upcoming PR, we will infer the transaction version in the same place.
This PR advances the state of #5164
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.