Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAML profiler: Make output user friendlier #6226

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

hurryabit
Copy link
Contributor

@hurryabit hurryabit commented Jun 4, 2020

In order to make the flamegraphs easier to consume by humans, we change
the profiler output in the following ways:

  1. Don't print package ids anymore. They are not particularly useful
    but cause a lot of noise.
  2. Remove a few useless angle bracket and move the printed names of
    DAML-LF closer to their surface level names.
  3. Unmangle identifiers on a best effort basis.
  4. Give the profiles shorter names such that they don't occupy the
    whole screen and leave some space for the navigation buttons of the
    Speedscope UI.

CHANGELOG_BEGIN
CHANGELOG_END

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This is part of #6199.


This change is Reviewable

In order to make the flamegraphs easier to consume by humans, we change
the profiler output in the following ways:

1. Don't print package ids anymore. They are not particularly useful
   but cause a lot of noise.
2. Remove a few useless angle bracket and move the printed names of
   DAML-LF closer to their surface level names.
3. Unmangle identifiers on a best effort basis.
4. Give the profiles shorter names such that they don't occupy the
   whole screen and leave some space for the navigation buttons of the
   Speedscope UI.

CHANGELOG_BEGIN
CHANGELOG_END
@martin-drhu-da martin-drhu-da force-pushed the profiler-friendlier-output branch from 1a5cac4 to 5961987 Compare June 4, 2020 15:16
Copy link
Collaborator

@remyhaemmerle-da remyhaemmerle-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Contributor

@nickchapman-da nickchapman-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 6d71475 into master Jun 4, 2020
@mergify mergify bot deleted the profiler-friendlier-output branch June 4, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants