Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle another potential initialization failure case #6202

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Handle another potential initialization failure case #6202

merged 1 commit into from
Jun 2, 2020

Conversation

shayne-fletcher
Copy link
Contributor

@shayne-fletcher shayne-fletcher commented Jun 2, 2020 •
edited
Loading

  • runWithACS can throw in the construction of its Flow. Handle that as an initialization failure.
  • test for the above
  • test for the case where execution fails for real.

@shayne-fletcher shayne-fletcher mentioned this pull request Jun 2, 2020
Merged
@shayne-fletcher shayne-fletcher force-pushed the trigger-error-test branch 2 times, most recently from f815213 to 7d9a41b Compare June 2, 2020 21:30
@shayne-fletcher shayne-fletcher requested a review from rohanjr June 2, 2020 21:31
@shayne-fletcher
Trigger error cases
ad88ad2 
changelog_begin
changelog_end
rohanjr
rohanjr approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@rohanjr rohanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as I understand it

triggers/service/src/test/scala/com/digitalasset/daml/lf/engine/trigger/ServiceTest.scala Show resolved Hide resolved
@shayne-fletcher shayne-fletcher merged commit 5ff8ec6 into master Jun 2, 2020
@shayne-fletcher shayne-fletcher deleted the trigger-error-test branch June 2, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanjr rohanjr rohanjr approved these changes

@cocreature cocreature Awaiting requested review from cocreature

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

@hurryabit hurryabit Awaiting requested review from hurryabit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shayne-fletcher @rohanjr