Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorten Windows CI username #6190

Merged
merged 1 commit into from
Jun 6, 2020
Merged

shorten Windows CI username #6190

merged 1 commit into from
Jun 6, 2020

Conversation

garyverhaegen-da
Copy link
Contributor

Keeping CI working on Windows involves a constant fight against MAX_PATH, which is a very short 260 characters. As the username appears in some paths, sometimes multiple times, we can save a few precious characters by having it shorter.

CHANGELOG_BEGIN
CHANGELOG_END

@garyverhaegen-da
shorten Windows CI username
fa6c769 
Keeping CI working on Windows involves a constant fight against
MAX_PATH, which is a very short 260 characters. As the username appears
in some paths, sometimes multiple times, we can save a few precious
characters by having it shorter.

CHANGELOG_BEGIN
CHANGELOG_END
@garyverhaegen-da
Copy link
Contributor Author

Assuming nobody objects to the PR, I'll try deploying it on Saturday, as it is potentially very disruptive. It looks innocuous, but:

  • It's a change to the Windows nodes config, so will require resetting all nodes, making Windows CI completely unavailable for about an hour, and
  • Despite our best efforts, absolute paths seem to leak into the Bazel cache keys on Windows, so this will likely require rebuilding the entire world, making all builds substantially slower for a while after the change.

cocreature
cocreature approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you need help resetting the cache let me know.

aherrmann-da
aherrmann-da approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@garyverhaegen-da
Copy link
Contributor Author

Thanks! If you need help resetting the cache let me know.

I was planning to do the simplest possible thing here: nothing. If the new path changes the cache key, the old cache file will just die off naturally as they get evicted, right? Or am I missing something?

hurryabit
hurryabit approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks.

@garyverhaegen-da
Copy link
Contributor Author

Successfully applied.

@garyverhaegen-da garyverhaegen-da merged commit b9fbba7 into master Jun 6, 2020
@garyverhaegen-da garyverhaegen-da deleted the shorten-windows-username branch June 6, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da aherrmann-da approved these changes

@hurryabit hurryabit hurryabit approved these changes

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
Standard-Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garyverhaegen-da @cocreature @hurryabit @aherrmann-da