automated ghc-lib build #6188
Merged
automated ghc-lib build #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyverhaegen-da
force-pushed
the
da-ghc-lib-gcs
branch
5 times, most recently
from
5c47b6d to
73730af
Compare
garyverhaegen-da
requested review from
cocreature,
shayne-fletcher and
SamirTalwar
|
This seems to work. My remaining concerns are:
|
cocreature
approved these changes
Jun 2, 2020
ghost
requested review from
ghost
approved these changes
Jun 3, 2020
ci/da-ghc-lib/compile.yml
Outdated
Comment on lines
26
to
27
| if [ "200" = "$(curl -Is "$URL_BASE/$LIB" | head -1 | awk '{print $2}')" ] \ | ||
| && [ "200" = "$(curl -Is "$URL_BASE/$PARSER" | head -1 | awk '{print $2}')" ]; then |
There was a problem hiding this comment.
Might be worth extracting the calls to curl | head | awk. If either of those fails due to a network connectivity issue (as opposed to printing "404"), I think we'd probably want to abort.
There was a problem hiding this comment.
Done, I think. Is this what you had in mind? Cursory testing in a shell does seem to indicate this would fail as expected, whereas the previous version wouldn't, as you suggested.
I've also added a -n to the gsutil cp commands so that even if we do end up running this when not needed, we would not overwrite the files.
garyverhaegen-da
force-pushed
the
da-ghc-lib-gcs
branch
from
fa83f23 to
99ad1db
Compare
This PR aims at automating the build of ghc-lib. The current process still has a few manual steps; it needs to be updated because Bintray is going away, so this seemed like a good opportunity to fully automate it. This works like the "patch bazel on Windows" jobs: the filename will contain a hash of the `ci/da-ghc-lib` folder, and the job will run only if the corresponding filename does not yet exist on the GCS bucket. PRs aiming at changing the ghc-lib version will need to run twice: once to create the artifacts, and once to change the `stack-snapshot.yaml` file to match. CHANGELOG_BEGIN CHANGELOG_END
garyverhaegen-da
force-pushed
the
da-ghc-lib-gcs
branch
from
99ad1db to
5084db0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at automating the build of ghc-lib. The current process still has a few manual steps; it needs to be updated because Bintray is going away, so this seemed like a good opportunity to fully automate it.
This works like the "patch bazel on Windows" jobs: the filename will contain a hash of the
ci/da-ghc-libfolder, and the job will run only if the corresponding filename does not yet exist on the GCS bucket. PRs aiming at changing the ghc-lib version will need to run twice: once to create the artifacts, and once to change thestack-snapshot.yamlfile to match.CHANGELOG_BEGIN
CHANGELOG_END