Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toxiproxy to Windows (for #6114) #6119

Merged
merged 1 commit into from
May 27, 2020

Conversation

garyverhaegen-da
Copy link
Contributor

I have never used Scoop before and I'm not sure how to actually test this, but I thought this might at least get a conversation going.

Plus, if my reading of the documentation of both toxiproxy and Scoop is correct, this may even work as is.

CHANGELOG_BEGIN
CHANGELOG_END

I have never used Scoop before and I'm not sure how to actually test
this, but I thought this might at least get a conversation going.

Plus, if my reading of the documentation of both toxiproxy and Scoop is
correct, this may even work as is.

CHANGELOG_BEGIN
CHANGELOG_END
"stack"
"python-3.8.2",
"stack",
"toxiproxy",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only real change here is adding this line, but I also sorted the list.

Copy link
Contributor

@aherrmann-da aherrmann-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@shayne-fletcher shayne-fletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @garyverhaegen-da! Thanks! When it lands, I'll take it out for a spin!

@garyverhaegen-da garyverhaegen-da merged commit b28b543 into master May 27, 2020
@garyverhaegen-da garyverhaegen-da deleted the add-toxiproxy-to-windows branch May 27, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants