Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON output to damlc inspect-dar #6076

Merged
merged 3 commits into from
May 22, 2020
Merged

Add JSON output to damlc inspect-dar #6076

merged 3 commits into from
May 22, 2020

Conversation

cocreature
Copy link
Contributor

fixes #3117, fixes #5563

This PR adds a --json flag to damlc inspect-dar that does pretty
much what you expect. So far it mainly exposes the same information
that you already got from inspect-dar but it’s easy to add more as
needed.

I’ve also finally added some documentation for inspect-dar.

changelog_begin

changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

fixes #3117, fixes #5563

This PR adds a `--json` flag to `damlc inspect-dar` that does pretty
much what you expect. So far it mainly exposes the same information
that you already got from `inspect-dar` but it’s easy to add more as
needed.

I’ve also finally added some documentation for `inspect-dar`.

changelog_begin

- [DAML Compiler] ``damlc inspect-dar`` now has a `--json`` flag to
  produce machine-readable output. See
  https://docs.daml.com/daml/reference/packages.html#inspecting-dars
  for more information.

changelog_end
changelog_begin
changelog_end
Copy link
Contributor

@rohanjr rohanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very useful, thanks!

docs/source/daml/reference/packages.rst Outdated Show resolved Hide resolved
Co-authored-by: Rohan Jacob-Rao <rohanjr@gmail.com>
@mergify mergify bot merged commit 2b1468e into master May 22, 2020
@mergify mergify bot deleted the inspect-json branch May 22, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants