Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle record dot syntax in DAML REPL #6028

Merged
merged 2 commits into from
May 19, 2020
Merged

Handle record dot syntax in DAML REPL #6028

merged 2 commits into from
May 19, 2020

Conversation

aherrmann-da
Copy link
Contributor

Closes #6015

  • Adds an export to the record dot preprocessor module for the expression preprocessor and uses it in the DAML REPL parser. We're parsing individual statements in the DAML REPL so we cannot apply the full module preprocessor.
  • Adds a regression test for record dot syntax entered into the DAML REPL.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@aherrmann-da aherrmann-da requested a review from cocreature May 19, 2020 12:20
@aherrmann-da aherrmann-da requested a review from hurryabit as a code owner May 19, 2020 12:20
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for fixing this so quickly!

aherrmann added 2 commits May 19, 2020 15:41
CHANGELOG_BEGIN
- [DAML REPL] Record dot syntax is now handled in expressions entered
  into the REPL.
CHANGELOG_END
@mergify mergify bot merged commit 2666c73 into master May 19, 2020
@mergify mergify bot deleted the repl-record-dot branch May 19, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RecordDotSyntax is broken in DAML Repl
3 participants