Run simplifier in topological order. #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiafaro-da
force-pushed
the
toposort-simplifier
branch
from
315f7c8 to
91ff3dc
Compare
cocreature
approved these changes
May 18, 2020
| w' = extendWorldSelf m' world | ||
| d' = simplifyDefValue w' dval | ||
| in NM.insert d' accum | ||
| in m { moduleValues = foldl' step NM.empty (topoSortDefValues m) } |
There was a problem hiding this comment.
This looks like you are reordering the values. I guess this doesn’t matter for anything?
There was a problem hiding this comment.
I think it's ok to reorder.
changelog_begin changelog_end
sofiafaro-da
force-pushed
the
toposort-simplifier
branch
from
bd70836 to
9fdc3e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the simplifier go through each value definition in topological order, instead of running all at once. This way optimizations can build on previous optimizations.
changelog_begin
changelog_end
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.