Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make max-inbound-message-size in DAML script/repl configurable #5996

Merged
merged 1 commit into from
May 15, 2020

Conversation

cocreature
Copy link
Contributor

Fixes #5592

The CLI syntax and the defaults follow the JSON API here.

changelog_begin

  • [DAML Script] The maximum inbound message size can now be configured
    using `--max-inbound-message-size``. This matches the flag in the JSON
    API.

  • [DAML REPL] The maximum inbound message size can now be configured
    using `--max-inbound-message-size``. This matches the flag in the JSON API.

changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

Fixes #5592

The CLI syntax and the defaults follow the JSON API here.

changelog_begin

- [DAML Script] The maximum inbound message size can now be configured
using `--max-inbound-message-size``. This matches the flag in the JSON
API.

- [DAML REPL] The maximum inbound message size can now be configured
using `--max-inbound-message-size``. This matches the flag in the JSON API.

changelog_end
@cocreature cocreature force-pushed the script-max-inbound-message-size branch from 1570726 to 2e5745b Compare May 15, 2020 10:22
Copy link
Contributor

@shayne-fletcher shayne-fletcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Party- and PackageManagementService missing from the docs
2 participants