Engine: Remove optionality of contract ID Seeding. #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
dasormeter,
fabiotudone-da,
gerolf-da,
hurryabit,
miklos-da,
mziolekda,
rautenrieth-da and
S11001001
as code owners
CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
force-pushed
the
remy-drop-relative-contract-id
branch
from
6ec6ea4 to
4bceaf7
Compare
ghost
reviewed
May 13, 2020
...-lf/interpreter/src/main/scala/com/digitalasset/daml/lf/transaction/PartialTransaction.scala
Outdated
Show resolved
Hide resolved
...-lf/interpreter/src/main/scala/com/digitalasset/daml/lf/transaction/PartialTransaction.scala
Outdated
Show resolved
Hide resolved
...f/transaction-scalacheck/src/main/scala/com/digitalasset/daml/lf/value/ValueGenerators.scala
Outdated
Show resolved
Hide resolved
...f/transaction-scalacheck/src/main/scala/com/digitalasset/daml/lf/value/ValueGenerators.scala
Outdated
Show resolved
Hide resolved
ghost
approved these changes
May 13, 2020
Co-authored-by: Samir Talwar <samir.talwar@digitalasset.com>
gerolf-da
approved these changes
May 13, 2020
remyhaemmerle-da
force-pushed
the
remy-drop-relative-contract-id
branch
from
da04792 to
1c31fcd
Compare
remyhaemmerle-da
changed the title
S11001001
approved these changes
May 13, 2020
Merged
6 tasks
miklos-da
reviewed
Jun 11, 2020
| @@ -1380,6 +1371,9 @@ class EngineTest extends WordSpec with Matchers with EitherValues with BazelRunf | |||
| "fetching contracts that have keys correctly fills in the transaction structure" when { | |||
| val fetchedCid = toContractId("#1") | |||
| val now = Time.Timestamp.now() | |||
| val submissionSeed = crypto.Hash.hashPrivateKey( | |||
| "fetching contracts that have keys correctly fills in the transaction structur") | |||
There was a problem hiding this comment.
...transaction structure
miklos-da
reviewed
Jun 11, 2020
| @@ -388,13 +388,15 @@ object Value extends CidContainer1WithDefaultCidResolver[Value] { | |||
| } | |||
|
|
|||
| object V1 { | |||
| val maxSuffixLength = 94 | |||
There was a problem hiding this comment.
I'm just wondering: from where does that magic number come from? If you would like to follow the Scala style guide this constant should be MaxSuffixLength.
remyhaemmerle-da
added a commit
that referenced
this pull request
Jun 11, 2020
remyhaemmerle-da
added a commit
that referenced
this pull request
Jun 11, 2020
remyhaemmerle-da
added a commit
that referenced
this pull request
Jun 11, 2020
CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
added a commit
that referenced
this pull request
Jun 11, 2020
CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
added a commit
that referenced
this pull request
Jun 11, 2020
CHANGELOG_BEGIN CHANGELOG_END
remyhaemmerle-da
added a commit
that referenced
this pull request
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.