Change references to replicateM to replicateA in dlint rules #5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - warn: {lhs: sequence_ (replicate n x), rhs: DA.Action.replicateM_ n x} | ||
| - warn: {lhs: mapA f (replicate n x), rhs: DA.Action.replicateM n (f x)} | ||
| - warn: {lhs: mapA_ f (replicate n x), rhs: DA.Action.replicateM_ n (f x)} | ||
| # TODO(DKT): Commented out because neither `mapAndUnzipA` nor `zipWithA` are in the stdlib |
There was a problem hiding this comment.
@da-tanabe I think just delete these. We can always add them back.
…some Haskell-based rules that do not yet apply in DAML. changelog_begin dlint: Change references to replicateM to replicateA; remove some Haskell-based rules that do not currently apply in DAML. changelog_end
da-tanabe
force-pushed
the
dlint-replicateAFix
branch
from
ac301dd to
9634052
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog_begin
Change references to replicateM to replicateA in dlint rules; remove some Haskell-based rules that do not yet apply in DAML.
changelog_end
Noticed this when writing
and dlint suggested:
When applying the fix, I also noticed a comment a few lines up about
zipWithAnot existing in the stdlib, so I commented out a few rules in the same block as well.