-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filterA to Prelude #5809
Add filterA to Prelude #5809
Conversation
Added filterA to Prelude.
6c90b92
to
049995a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! Couple of suggestions inline.
Co-authored-by: Shayne Fletcher <shayne@shaynefletcher.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to see a test added for this but given the apparent absence of tests for the other DA.Action
functions, I think this could be done in a follow up PR.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
dea556d
to
05655b3
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
CHANGELOG_END
ae37e30
to
9c70405
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Pull Request Checklist
CHANGELOG_BEGIN
andCHANGELOG_END
tagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines run
totrigger the build.
filterA
Implemented a
filterA
function using the approach borrowed frommapA
in the standard library (and thefilterM
in Haskell).Given the "classic" Iou example if one has a collection of
ContractId Iou
s and is interested in only the "large ones" he could use this new filter like this: