Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch zip library to not use temp files #5621

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Patch zip library to not use temp files #5621

merged 1 commit into from
Apr 20, 2020

Conversation

cocreature
Copy link
Contributor

This should hopefully fix the issues we have been seeing on CI. While
I’m not super keen on including non-upstreamable patches it seems
better than having CI be flaky.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature
Patch zip library to not use temp files
4723ae4 
This should hopefully fix the issues we have been seeing on CI. While
I’m not super keen on including non-upstreamable patches it seems
better than having CI be flaky.

changelog_begin
changelog_end
@cocreature cocreature requested a review from aherrmann-da April 20, 2020 07:34
ghost
ghost approved these changes Apr 20, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

Are you gonna try and push this upstream, perhaps as an option or something that's only done on Windows?

@cocreature
Copy link
Contributor Author

Are you gonna try and push this upstream, perhaps as an option or something that's only done on Windows?

Not sure how much sense that makes. The code in the zip library is perfectly fine. It’s openBinaryTempFile that is broken. I think there is some fix in 8.10 but @aherrmann-da managed to reproduce it there as well so something else seems to be broken.

@mergify mergify bot merged commit db37e4c into master Apr 20, 2020
@mergify mergify bot deleted the zip-no-temp branch April 20, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann-da aherrmann-da Awaiting requested review from aherrmann-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cocreature