embryonic Slack notification for master builds #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyverhaegen-da
force-pushed
the
slack-notifications
branch
2 times, most recently
from
907c59b to
67585c5
Compare
dbreydo-da
approved these changes
Apr 16, 2019
garyverhaegen-da
force-pushed
the
slack-notifications
branch
3 times, most recently
from
9b4c6cc to
fa35474
Compare
cocreature
reviewed
Apr 17, 2019
azure-pipelines.yml
Outdated
|
|
||
| - job: notify | ||
| dependsOn: ["linux", "macos", "windows", "release"] | ||
| condition: always() #eq(variables['Build.SourceBranchName'], 'master') |
There was a problem hiding this comment.
I guess you only disabled this for testing?
There was a problem hiding this comment.
Yes, will definitely re-enable before merging.
garyverhaegen-da
force-pushed
the
slack-notifications
branch
5 times, most recently
from
75b5039 to
3cda712
Compare
garyverhaegen-da
force-pushed
the
slack-notifications
branch
4 times, most recently
from
17e3a5e to
7cdbc53
Compare
garyverhaegen-da
force-pushed
the
slack-notifications
branch
from
7cdbc53 to
8c4263c
Compare
flokli
reviewed
Apr 26, 2019
| @@ -25,6 +25,14 @@ jobs: | |||
| - template: ci/build-unix.yml | |||
| parameters: | |||
| name: linux | |||
| - bash: | | |||
There was a problem hiding this comment.
hoping azures' yaml parser supports this: can we use anchors and merge keys to reduce code duplication?
There was a problem hiding this comment.
/azure-pipelines.yml: Anchors are not currently supported. Remove the anchor 'SLACK'
Nope :(
There was a problem hiding this comment.
garyverhaegen-da
force-pushed
the
slack-notifications
branch
from
b33d278 to
8c4263c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.