Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions #5560

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Update release instructions #5560

merged 1 commit into from
Apr 15, 2020

Conversation

cocreature
Copy link
Contributor

This PR updates two points in the release process:

  1. The process for getting release notes for a stable release based on
    my experience of doing that for the past 2 releases.
  2. It adds testing for the getting started guide. I did not remove the
    testing of quickstart-java. I do want to test scenarios and
    navigator and a bit of VSCode so the only potentially redundant
    point there is the mvn compile step but that verifies that Maven
    artifacts have been published successfully so I think it is still
    useful.

changelog_begin
changelog_end

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

This PR updates two points in the release process:

1. The process for getting release notes for a stable release based on
   my experience of doing that for the past 2 releases.
1. It adds testing for the getting started guide. I did not remove the
   testing of `quickstart-java`. I do want to test scenarios and
   navigator and a bit of VSCode so the only potentially redundant
   point there is the `mvn compile` step but that verifies that Maven
   artifacts have been published successfully so I think it is still
   useful.

changelog_begin
changelog_end
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this all down. I'm a bit concerned that this is starting to be a lot of manual testing, but I don't have a better answer at the moment :(

@cocreature
Copy link
Contributor Author

I'm a bit concerned that this is starting to be a lot of manual testing, but I don't have a better answer at the moment :(

Yeah I fully agree but I don’t have a solution here either. To give some frame of reference, it takes me less than an hour to run through this on two platforms. While an hour is a lot, as long as we actually do one release per week instead of 5 and we distribute the work so it’s not the same person doing it over and over, I think it’s probably acceptable at least in the short term. Not really sure what we do in the long-term, I don’t see any obvious steps in here that we could just kill. Most of them have caught bugs in the recent past.

@cocreature cocreature merged commit 3c03911 into master Apr 15, 2020
@cocreature cocreature deleted the release-instructions branch April 15, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants