Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Windows agents #5527

Merged
merged 1 commit into from
Apr 14, 2020
Merged

replace Windows agents #5527

merged 1 commit into from
Apr 14, 2020

Conversation

garyverhaegen-da
Copy link
Contributor

@garyverhaegen-da garyverhaegen-da commented Apr 9, 2020

It looks like the change in Windows agent names has caused an issue: because Windows agents are not always properly cleaned up on shutdown, i.e. they do not always have time to tell Azure they are going away, and because GCP likes to reuse the same names for machines in a group, we've been seeing errors like:

ERROR: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Pool 11 already contains an agent with name VSTS-WIN-3QCX.

recently. Today, only 2 out of our 6 agents have managed to register with Azure. This PR should fix that.

ChaNGELOG_BEGIN
CHANGELOG_END

It looks like the change in Windows agent names has caused an issue:
because Windows agents are not always properly cleaned up on shutdown,
i.e. they do not always have time to tell Azure they are going away, and
because GCP likes to reuse the same names for machines in a group, we've
been seeing errors like:

```
ERROR: The running command stopped because the preference variable
"ErrorActionPreference" or common parameter is set to Stop: Pool 11
already contains an agent with name VSTS-WIN-3QCX.
```

recently. Today, only 2 out of our 6 agents have managed to register
with Azure. This PR should fix that.

ChaNGELOG_BEGIN
CHANGELOG_END
Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@garyverhaegen-da
Copy link
Contributor Author

Since we seem to have a bit of activity still tonight, I'm going to manually repair the current situation (i.e. delete "failed" agents from Azure then delete the corresponding machines on GCP).

Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@garyverhaegen-da
Copy link
Contributor Author

Can confirm we're back to 6 working agents. Will keep an eye on this tomorrow and merge over the weekend.

@garyverhaegen-da garyverhaegen-da merged commit 08a5a64 into master Apr 14, 2020
@garyverhaegen-da garyverhaegen-da deleted the replace-windows-agents branch April 14, 2020 11:58
@garyverhaegen-da
Copy link
Contributor Author

Just deployed 08a5a64 and confirmed everything is working. (As well as before, at least.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants