Relabel "Experimental" to "Early Access" and reorganise pages #5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bame-da
requested review from
cocreature,
rohanjr,
hurryabit,
gerolf-da and
nemanja-da
bame-da
force-pushed
the
experimental-feature-tidyup
branch
from
a5ce094 to
3beaf33
Compare
cocreature
reviewed
Apr 3, 2020
| app-dev/bindings-ts/index | ||
| app-dev/bindings-java/index |
There was a problem hiding this comment.
What is happening to those? You seem to have removed them from the index but it looks like you didn’t believe the files.
There was a problem hiding this comment.
Ah I missed that we have a separate index for the ledger API, thanks for the explanation!
|
Moved them below the "The Ledger API" item. I tried to bundle everything
related to direct interaction with the Ledger API there.
…On Fri, 3 Apr 2020, 12:01 Moritz Kiefer, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/source/index.rst
<#5411 (comment)>:
> app-dev/bindings-ts/index
- app-dev/bindings-java/index
What is happening to those? You seem to have removed them from the index
but it looks like you didn’t believe the files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5411 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJW7WQUMCBZKEH2CR3UC6STRKWXVXANCNFSM4L3X6ASA>
.
--
This message, and any attachments, is for the intended recipient(s) only,
may contain information that is privileged, confidential and/or proprietary
and subject to important terms and conditions available at
http://www.digitalasset.com/emaildisclaimer.html
<http://www.digitalasset.com/emaildisclaimer.html>. If you are not the
intended recipient, please delete this message.
|
CHANGELOG_BEGIN - Move daml2ts, bindings-ts and JSON API out of experimental section in docs - Rename Experimental to Early Access in docs and assistant - Reorganise the docs a little bit to de-emphasise the Ledger API CHANGELOG_END
bame-da
force-pushed
the
experimental-feature-tidyup
branch
from
3beaf33 to
444a810
Compare
hurryabit
approved these changes
Apr 3, 2020
|
You can move the files around if you want to. Moving files and reshuffling the index are completely orthogonal. Since I took your suggestion of moving the quickstart under the java bindings, I don't think there's a real conflict here, probably a merge conflict, though. |
S11001001
added a commit
that referenced
this pull request
Apr 3, 2020
- pointed out by @cocreature; thanks
S11001001
added a commit
that referenced
this pull request
Apr 3, 2020
* move JSON API doc to "Building applications" * stop describing JSON API as experimental; limit to calling WebSocket endpoints alpha * remove "(experimental)" from daml json-api docstring * add changelog CHANGELOG_BEGIN - [JSON API] First stable version of the ``/v1`` endpoints, with the exception of the WebSocket endpoints, which remain in alpha. See `issue #4458 <https://github.com/digital-asset/daml/issues/4458>`_. CHANGELOG_END * move json-api in PDF ToC, adapting to #5411 c496e2b - pointed out by @cocreature; thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #5407 and #5408. It's likely to lead to conflicts with some other changes by @S11001001 and @rohanjr, but I thought I'd present my complete suggestion for the tidyup.
CHANGELOG_BEGIN
daml2ts,bindings-tsand JSON API out of experimental section in docsCHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.