Rename daml2ts to daml2js #5394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty much a search and replace over the whole repo, including file names. CHANGELOG_BEGIN CHANGELOG_END
hurryabit
force-pushed
the
daml2ts-becomes-daml2js
branch
from
1f02611 to
c763dd3
Compare
shayne-fletcher
approved these changes
Apr 3, 2020
hurryabit
requested review from
bame-da,
cocreature and
nemanja-da
as code owners
cocreature
approved these changes
Apr 3, 2020
| runDaml2js remainingArgs = do | ||
| daml2js <- fmap (</> "daml2js" </> "daml2js") getSdkPath | ||
| withProcessWait_' (proc daml2js remainingArgs) (const $ pure ()) `catchIO` | ||
| (\e -> hPutStrLn stderr "Failed to invoke daml2js." *> throwIO e) |
There was a problem hiding this comment.
Shouldn’t this say daml codegen js. The executable invoked by that seems like an implementation detail.
| @@ -1,25 +1,25 @@ | |||
| .. Copyright (c) 2020 Digital Asset (Switzerland) GmbH and/or its affiliates. All rights reserved. | |||
| .. SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| ``daml2ts`` - TypeScript code generator for DAML | |||
| ``daml2js`` - TypeScript code generator for DAML | |||
There was a problem hiding this comment.
Somewhat similar question. I think it’s slightly confusing to have this called daml2js while the command is called daml codegen js.
|
I agree regarding the docs. I'll have a walk through the docs today and look at all occurrences of |
|
@hurryabit @Robin-da Note that we need to update the architecture diagrams then as well as they're pointing to daml2ts at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty much a search and replace over the whole repo, including
file names.
This does not yet add the
daml codegen jscommand. We'll do thatin a separate PR.
CHANGELOG_BEGIN
CHANGELOG_END
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.
This change is