Replace quickstart with new getting started guide #5392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanjr
requested review from
cocreature,
hurryabit,
gerolf-da,
bame-da and
nemanja-da
|
Thnx for the great work @rohanjr! Any chance you could squeeze in this PR a small change for the GSG? The footnote in the app architecture section for the React Ledger library is broken (nothing to do with this PR though). It should point out to app-dev/bindings-ts/daml-ledger/index.html On another note: why isn't the testing your app section part of the GSG? |
bame-da
reviewed
Apr 3, 2020
docs/redirects.map
Outdated
| @@ -10,7 +10,7 @@ daml/anti-patterns.html | |||
| daml/models-versus-application.html | |||
| daml/stdlib/base.html -> daml/reference/base.html | |||
| concepts.html -> /concepts/ledger-model/index.html | |||
| getting-started.html -> /getting-started/quickstart.html | |||
| getting-started.html -> /app-dev/bindings-java/quickstart.html | |||
There was a problem hiding this comment.
I think we should point this to the new GSG. We are allowed to change the content of pages, we just don't want dead links.
There was a problem hiding this comment.
I don't actually know what this redirects map is, but I made the change.
docs/redirects.map
Outdated
| @@ -52,7 +52,7 @@ packages/navigator-docs/database.html -> /tools/navigator/database.html | |||
| packages/navigator-docs/backend-licenses.html -> / | |||
| packages/navigator-docs/console.html -> /tools/navigator/console.html | |||
| packages/navigator-docs/frontend-licenses.html -> / | |||
| packages/quickstart/index.html -> /getting-started/quickstart.html | |||
| packages/quickstart/index.html -> /app-dev/bindings-java/quickstart.html | |||
rohanjr
force-pushed
the
gsg-replace-quickstart
branch
from
e465bdf to
fd452e6
Compare
|
@nemanja-da I fixed that link |
6 tasks
changelog_begin - [Docs] Replace IOU quickstart with full stack Getting Started Guide changelog_end
rohanjr
force-pushed
the
gsg-replace-quickstart
branch
from
fd452e6 to
b266a73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the new guide into the Getting Started section, following Installation. I moved the IOU Quickstart to the Java Bindings section. I did not change its content besides the title.
I also updated the many references to the Quickstart to the new location, but I did not attempt to update them to point to the new guide when it makes sense. This is really just a minimal change to get the new guide in the right spot.
Pull Request Checklist
CHANGELOG_BEGINandCHANGELOG_ENDtagsNOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with
/AzurePipelines runtotrigger the build.