Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze JSON API v1 #5387

Merged
merged 7 commits into from
Apr 3, 2020
Merged

Freeze JSON API v1 #5387

merged 7 commits into from
Apr 3, 2020

Conversation

S11001001
Copy link
Contributor

Fixes #4458.

Pull Request Checklist

  • Read and understand the contribution guidelines
  • Include appropriate tests
  • Set a descriptive title and thorough description
  • Add a reference to the issue this PR will solve, if appropriate
  • Include changelog additions in one or more commit message bodies between the CHANGELOG_BEGIN and CHANGELOG_END tags
  • Normal production system change, include purpose of change in description

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

S11001001 added 4 commits April 2, 2020 12:53
@S11001001
move JSON API doc to "Building applications"
4b8b505
@S11001001
stop describing JSON API as experimental; limit to calling WebSocket …
85a0416 
…endpoints alpha
@S11001001
remove "(experimental)" from daml json-api docstring
9babc7b
@S11001001
add changelog
4933012 
CHANGELOG_BEGIN
- [JSON API] First stable version of the ``/v1`` endpoints, with
  the exception of the WebSocket endpoints, which remain in alpha.
  See `issue #4458 <https://github.com/digital-asset/daml/issues/4458>`_.
CHANGELOG_END
@S11001001 S11001001 added this to the HTTP JSON API Maintenance milestone Apr 2, 2020
@S11001001 S11001001 self-assigned this Apr 2, 2020
leo-da
leo-da approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@leo-da leo-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gerolf-da
gerolf-da approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@gerolf-da gerolf-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @S11001001!

hurryabit
hurryabit approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks a lot.

docs/source/index.rst Show resolved Hide resolved
cocreature
cocreature reviewed Apr 3, 2020
View reviewed changes
docs/source/index.rst Outdated Show resolved Hide resolved
@S11001001 S11001001 merged commit ff68252 into master Apr 3, 2020
@S11001001 S11001001 deleted the 4458-freeze-json-api-v1 branch April 3, 2020 17:58
@stefanobaghino-da stefanobaghino-da added the team/ledger-clients Related to the Ledger Clients team's components. label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hurryabit hurryabit hurryabit approved these changes

@cocreature cocreature cocreature left review comments

@gerolf-da gerolf-da gerolf-da approved these changes

@leo-da leo-da leo-da approved these changes

@bame-da bame-da Awaiting requested review from bame-da

@nemanja-da nemanja-da Awaiting requested review from nemanja-da

Assignees

@S11001001 S11001001

Labels
component/documentation component/json-api HTTP JSON API DAML SDK 1.0 team/ledger-clients Related to the Ledger Clients team's components.
Projects
None yet
Milestone
HTTP JSON API Maintenance
Development

Successfully merging this pull request may close these issues.

Freeze API v1
6 participants
@S11001001 @cocreature @hurryabit @leo-da @gerolf-da @stefanobaghino-da